Conversation
I, Samuel Babak <samuel.babak@sas.com>, hereby add my Signed-off-by to this commit: 48eaf3b I, Samuel Babak <samuel.babak@sas.com>, hereby add my Signed-off-by to this commit: b297a14 I, Samuel Babak <samuel.babak@sas.com>, hereby add my Signed-off-by to this commit: 20dd957 Signed-off-by: Samuel Babak <samuel.babak@sas.com>
Signed-off-by: Samuel Babak <samuel.babak@sas.com>
Signed-off-by: Samuel Babak <samuel.babak@sas.com>
Signed-off-by: Samuel Babak <samuel.babak@sas.com>
Signed-off-by: Samuel Babak <samuel.babak@sas.com>
| ] | ||
|
|
||
|
|
||
| IMPORT_TO_INSTALL_MAPPING = { |
There was a problem hiding this comment.
Could the addition of this import to install mapping create some issues with backwards compatibility? I noticed that in the example files it directs users to manually change the import names for packages like sklearn.
There was a problem hiding this comment.
No, I think we're good here, since it was a non-programmatic ask. If they go hunting to change something and find it's fixed, I doubt we'll get complaints.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I, Samuel Babak <samuel.babak@sas.com>, hereby add my Signed-off-by to this commit: e72465e Signed-off-by: Samuel Babak <samuel.babak@sas.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 64.17% 64.26% +0.09%
==========================================
Files 57 57
Lines 6230 6286 +56
==========================================
+ Hits 3998 4040 +42
- Misses 2232 2246 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ] | ||
|
|
||
|
|
||
| IMPORT_TO_INSTALL_MAPPING = { |
There was a problem hiding this comment.
No, I think we're good here, since it was a non-programmatic ask. If they go hunting to change something and find it's fixed, I doubt we'll get complaints.
2 participants
Add requirements.txt generation support
Summary: Adds optional create_requirements_txt parameter to create_requirements_json() function for SAS Event Stream Processing compatibility.
Changes:
New create_requirements_txt: bool = False parameter (backward compatible)
Generates standard pip requirements.txt format (package==version)
Creates file in same output path as requirements.json
Updated docstring documentation
Usage:
JSONFiles.create_requirements_json(
output_path="./output",
create_requirements_txt=True
)
Fixes: EDMMMX-13491